New Feature: Add price alert for a stock#68
Open
asifma wants to merge 4 commits into
Open
Conversation
Open
fhqvst
reviewed
Sep 1, 2021
fhqvst
left a comment
fhqvst
left a comment
Owner
There was a problem hiding this comment.
Great! Thanks! Should we add a removePriceAlert too?
Author
|
I just haven't had time to look at it yet. But in order to remove alerts, you need to (per my understanding).
So yes, we should probably introduce getPriceAlert & removePriceAlert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addPriceAlert
Add an price alert.
Parameters
instrumentId[String][52] The ID of the instrument to add.options[Object][51] Alert options.options.price[Number][54] The target price to receive an alert on.options.validUntil[String][52] A date on the form YYYY-MM-DD. Cancels alert if this date is