Fix Capture::Tiny trailing newline issue in subprocess output#756
Merged
Conversation
Changed stream routing from line-based to byte-based to preserve exact output including or excluding trailing newlines. The previous implementation used BufferedReader.readLine() which strips newlines, then added them back, causing incorrect behavior when subprocess output didn't have trailing newlines. - Modified createStreamRouterThread to read raw bytes - Created writeToPerlStdoutBytes and writeToPerlStderrBytes methods - Removed unused string-based methods (writeToPerlStdout, writeToPerlStderr) Test results: Reduced test failures from 50 to 36 out of 331 tests. Remaining failures are unicode encoding issues (separate problem).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed stream routing from line-based to byte-based to preserve exact output including or excluding trailing newlines. Test failures reduced from 50 to 36 out of 331 tests. Remaining failures are unicode encoding issues (separate problem).