Skip to content

fix(seo): include published Big Five hub in sitemap and llms discovery#2818

Merged
fermatmind merged 1 commit into
mainfrom
fix/sitemap-hub-discoverability
Jul 8, 2026
Merged

fix(seo): include published Big Five hub in sitemap and llms discovery#2818
fermatmind merged 1 commit into
mainfrom
fix/sitemap-hub-discoverability

Conversation

@fermatmind

Copy link
Copy Markdown
Owner

Problem

/zh/personality/big-five Hub has index_eligible=1, robots=index,follow, sitemap_eligible=1, llms_eligible=1, launch_state=published, review_state=seo_discoverability_released. But the Hub was excluded from sitemap.xml, llms.txt, and llms-full.txt.

Root cause

  1. SitemapGenerator::getPersonalityPublicContentAssetUrls() had whereIn('entity_type', ['domain', 'polarity']) — hub excluded.
  2. The path guard str_starts_with(/Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /Users/rainie/.workbuddy/binaries/node/versions/22.22.2/bin /Users/rainie/.workbuddy/binaries/python/versions/3.13.12/bin /Users/rainie/.workbuddy/binaries/node/cli-connector-packages/bin /Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /usr/local/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/bin /Users/rainie/.npm-global/bin /usr/local/bin /Users/rainie/.local/node20/bin /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /pkg/env/global/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/.npm-global/bin, '/zh/personality/big-five/') required trailing slash — Hub path (/zh/personality/big-five) failed.

Fix

  • Add ENTITY_HUB to whereIn filter
  • Accept path /zh/personality/big-five without trailing slash

Safety gates

  • All existing strictness gates preserved
  • Only published, eligible hubs are included
  • noindex/draft hubs remain excluded (tested)
  • Domain/polarity pages unaffected (no regression)

Tests

  • Hub included in sitemap when published and eligible
  • noindex hub excluded
  • draft hub excluded
  • All 9 existing SitemapGeneratorTest tests pass
  • All 43 related tests pass

Runtime impact

  • sitemap-source will include Hub on next warm
  • sitemap.xml, llms.txt, llms-full.txt will include Hub

Search submission impact: none

Deployment impact: not executed

Explicitly deferred

  • facet_hub discoverability
  • Enneagram/RIASEC hubs
  • BigFiveSeoDiscoverabilityReleaseWriter hub gate (DB already fixed)
  • content changes
  • search submission

Problem:
/zh/personality/big-five Hub has index_eligible=1, robots=index,follow,
sitemap_eligible=1, llms_eligible=1, launch_state=published,
review_state=seo_discoverability_released.
But the Hub was excluded from sitemap.xml, llms.txt, and llms-full.txt.

Root cause:
1. SitemapGenerator::getPersonalityPublicContentAssetUrls() had
   whereIn('entity_type', ['domain', 'polarity']) — hub excluded.
2. The path guard str_starts_with(/Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /Users/rainie/.workbuddy/binaries/node/versions/22.22.2/bin /Users/rainie/.workbuddy/binaries/python/versions/3.13.12/bin /Users/rainie/.workbuddy/binaries/node/cli-connector-packages/bin /Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /usr/local/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/bin /Users/rainie/.npm-global/bin /usr/local/bin /Users/rainie/.local/node20/bin /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /pkg/env/global/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/.npm-global/bin, '/zh/personality/big-five/')
   required trailing slash — Hub path (/zh/personality/big-five) failed.

Fix:
- Add ENTITY_HUB to whereIn filter
- Accept path '/zh/personality/big-five' without trailing slash

Safety gates:
- All existing strictness gates preserved (index_eligible, robots,
  sitemap_eligible, llms_eligible, launch_state=published,
  review_state=seo_discoverability_released)
- Only published, eligible hubs are included
- noindex/draft hubs remain excluded (tested)
- Private URL guard unchanged
- Domain/polarity pages unaffected (no regression)

Tests:
- Hub included in sitemap when published and eligible
- noindex hub excluded
- draft hub excluded
- All 9 existing SitemapGeneratorTest tests pass
- All 43 related tests pass (SitemapSource/BigFiveCms/BigFiveSeo/SitemapWarm)

Runtime impact:
- sitemap-source will include Hub on next warm
- sitemap.xml, llms.txt, llms-full.txt will include Hub

Search submission impact: none
Deployment impact: not executed

Explicitly deferred:
- facet_hub discoverability
- Enneagram/RIASEC hubs
- BigFiveSeoDiscoverabilityReleaseWriter hub gate (DB already fixed)
- content changes
- search submission
@fermatmind fermatmind merged commit a22c169 into main Jul 8, 2026
15 checks passed
@fermatmind fermatmind deleted the fix/sitemap-hub-discoverability branch July 8, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant