fix(seo): include published Big Five hub in sitemap and llms discovery#2818
Merged
Conversation
Problem:
/zh/personality/big-five Hub has index_eligible=1, robots=index,follow,
sitemap_eligible=1, llms_eligible=1, launch_state=published,
review_state=seo_discoverability_released.
But the Hub was excluded from sitemap.xml, llms.txt, and llms-full.txt.
Root cause:
1. SitemapGenerator::getPersonalityPublicContentAssetUrls() had
whereIn('entity_type', ['domain', 'polarity']) — hub excluded.
2. The path guard str_starts_with(/Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /Users/rainie/.workbuddy/binaries/node/versions/22.22.2/bin /Users/rainie/.workbuddy/binaries/python/versions/3.13.12/bin /Users/rainie/.workbuddy/binaries/node/cli-connector-packages/bin /Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /usr/local/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/bin /Users/rainie/.npm-global/bin /usr/local/bin /Users/rainie/.local/node20/bin /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /pkg/env/global/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/.npm-global/bin, '/zh/personality/big-five/')
required trailing slash — Hub path (/zh/personality/big-five) failed.
Fix:
- Add ENTITY_HUB to whereIn filter
- Accept path '/zh/personality/big-five' without trailing slash
Safety gates:
- All existing strictness gates preserved (index_eligible, robots,
sitemap_eligible, llms_eligible, launch_state=published,
review_state=seo_discoverability_released)
- Only published, eligible hubs are included
- noindex/draft hubs remain excluded (tested)
- Private URL guard unchanged
- Domain/polarity pages unaffected (no regression)
Tests:
- Hub included in sitemap when published and eligible
- noindex hub excluded
- draft hub excluded
- All 9 existing SitemapGeneratorTest tests pass
- All 43 related tests pass (SitemapSource/BigFiveCms/BigFiveSeo/SitemapWarm)
Runtime impact:
- sitemap-source will include Hub on next warm
- sitemap.xml, llms.txt, llms-full.txt will include Hub
Search submission impact: none
Deployment impact: not executed
Explicitly deferred:
- facet_hub discoverability
- Enneagram/RIASEC hubs
- BigFiveSeoDiscoverabilityReleaseWriter hub gate (DB already fixed)
- content changes
- search submission
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/zh/personality/big-five Hub has index_eligible=1, robots=index,follow, sitemap_eligible=1, llms_eligible=1, launch_state=published, review_state=seo_discoverability_released. But the Hub was excluded from sitemap.xml, llms.txt, and llms-full.txt.
Root cause
whereIn('entity_type', ['domain', 'polarity'])— hub excluded.str_starts_with(/Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /Users/rainie/.workbuddy/binaries/node/versions/22.22.2/bin /Users/rainie/.workbuddy/binaries/python/versions/3.13.12/bin /Users/rainie/.workbuddy/binaries/node/cli-connector-packages/bin /Applications/WorkBuddy.app/Contents/Resources/app.asar.unpacked/cli/vendor/shim/safe-bin /usr/local/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/bin /Users/rainie/.npm-global/bin /usr/local/bin /Users/rainie/.local/node20/bin /opt/homebrew/bin /opt/homebrew/sbin /usr/local/bin /System/Cryptexes/App/usr/bin /usr/bin /bin /usr/sbin /sbin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin /var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin /pkg/env/global/bin /Users/rainie/.local/node20/bin /Users/rainie/bin /Users/rainie/.npm-global/bin, '/zh/personality/big-five/')required trailing slash — Hub path (/zh/personality/big-five) failed.Fix
ENTITY_HUBtowhereInfilter/zh/personality/big-fivewithout trailing slashSafety gates
Tests
Runtime impact
Search submission impact: none
Deployment impact: not executed
Explicitly deferred