Skip to content

feat: use shared source resolver#87

Merged
ngleanh merged 1 commit into
mainfrom
codex/use-public-source-resolver
Jun 24, 2026
Merged

feat: use shared source resolver#87
ngleanh merged 1 commit into
mainfrom
codex/use-public-source-resolver

Conversation

@ngleanh

@ngleanh ngleanh commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Problem

ff-cli find still owned its marketplace URL parsing locally, while the resolver logic now lives in the public feral-file/ff-source-resolver library. Keeping both copies makes supported URL coverage drift and duplicates resolver maintenance.

Why it matters

The CLI should consume the shared resolver so supported site URL parsing stays aligned with the resolver automation and its site-specific modules.

Changes

  • Depend on @feralfile/source-resolver from the public feral-file/ff-source-resolver repo, pinned to commit 135de86b82f5b9dd0795d98aa1754217640d6b43.
  • Replace local marketplace parser imports with the shared package.
  • Remove the local src/utilities/marketplace-url.ts copy.
  • Add parser coverage for current Art Blocks token URLs and fxhash iteration id URLs.

Acceptance checks

  • npm run verify
  • node --import tsx --test tests/find.test.ts tests/opensea-collection.test.ts
  • Clean install smoke: copied repo to /tmp, ran GIT_SSH_COMMAND=false npm ci --ignore-scripts successfully.
  • In-app browser picked live pages, then CLI find --limit 1 and validate succeeded for:
    • https://www.artblocks.io/collection/ringers-by-dmitri-cherniak
    • https://verse.works/items/ethereum/0x23b72f7458a204446983f544d655df10f70533e9/139
    • https://www.raster.art/artwork/split-logic-by-ricky-retouch

Review

Fresh-context review using prompts/code-review.md: Verdict: accept.

@feralfile-bot feralfile-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewers: 3 (approve: 3, comment: 0, request-changes: 0).

No meaningful findings remain after consolidation. All three independent reviewers approved and reported no critical issues, medium issues, missing tests, or optional cleanup. There was no PR discussion context indicating deferred or recurring concerns to carry forward.

@feralfile-bot

Copy link
Copy Markdown
Contributor

Automated human review request for PR #87.

Risk zone: red
Responsibility area: FF CLI publish-and-validate input resolution
Why this needs human review: This PR adds a new external dependency and changes a canonical runtime parsing contract on the publish-and-validate path, so steward review is warranted even with automated tests passing.

This PR needs targeted human review on the scoped areas below, not a full second pass of the whole PR.

  • @jollyjoker992: please review Review the shared @feralfile/source-resolver adoption, the removed local marketplace parser, and the URL parsing contract in find/play plus the updated Art Blocks and fxhash coverage. Context: FF CLI steward for the canonical publish-and-validate path (Hieu Pham).

@ngleanh ngleanh merged commit 0fc8249 into main Jun 24, 2026
6 checks passed
@ngleanh ngleanh deleted the codex/use-public-source-resolver branch June 24, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants