feat: use shared source resolver#87
Conversation
feralfile-bot
left a comment
There was a problem hiding this comment.
Reviewers: 3 (approve: 3, comment: 0, request-changes: 0).
No meaningful findings remain after consolidation. All three independent reviewers approved and reported no critical issues, medium issues, missing tests, or optional cleanup. There was no PR discussion context indicating deferred or recurring concerns to carry forward.
|
Automated human review request for PR #87. Risk zone: red This PR needs targeted human review on the scoped areas below, not a full second pass of the whole PR.
|
Problem
ff-cli findstill owned its marketplace URL parsing locally, while the resolver logic now lives in the publicferal-file/ff-source-resolverlibrary. Keeping both copies makes supported URL coverage drift and duplicates resolver maintenance.Why it matters
The CLI should consume the shared resolver so supported site URL parsing stays aligned with the resolver automation and its site-specific modules.
Changes
@feralfile/source-resolverfrom the publicferal-file/ff-source-resolverrepo, pinned to commit135de86b82f5b9dd0795d98aa1754217640d6b43.src/utilities/marketplace-url.tscopy.Acceptance checks
npm run verifynode --import tsx --test tests/find.test.ts tests/opensea-collection.test.ts/tmp, ranGIT_SSH_COMMAND=false npm ci --ignore-scriptssuccessfully.find --limit 1andvalidatesucceeded for:https://www.artblocks.io/collection/ringers-by-dmitri-cherniakhttps://verse.works/items/ethereum/0x23b72f7458a204446983f544d655df10f70533e9/139https://www.raster.art/artwork/split-logic-by-ricky-retouchReview
Fresh-context review using
prompts/code-review.md:Verdict: accept.