Skip to content

#461 — Add commas to single-item lists#624

Closed
lwasyl wants to merge 3 commits into
fbtransfer:mainfrom
lwasyl:wasyl/461-single-param-commas
Closed

#461 — Add commas to single-item lists#624
lwasyl wants to merge 3 commits into
fbtransfer:mainfrom
lwasyl:wasyl/461-single-param-commas

Conversation

@lwasyl

@lwasyl lwasyl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Fixes #461

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 4, 2026
@hick209

hick209 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@nreid260 thoughts?

@lwasyl

lwasyl commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@hick209 just for context, since I haven't posted in the issue — I felt there's general consensus that these trailing commas would be useful, so figured I'd open the PR in case it was just that nobody got around to implementing it

@hick209

hick209 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Rebase, update CHANGELOG.md and we might take this in

@lwasyl
lwasyl force-pushed the wasyl/461-single-param-commas branch from 80585ff to fbef9e6 Compare July 1, 2026 08:40
@lwasyl
lwasyl marked this pull request as ready for review July 1, 2026 15:32
@lwasyl

lwasyl commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@hick209 done!

@meta-codesync

meta-codesync Bot commented Jul 1, 2026

Copy link
Copy Markdown

@hick209 has imported this pull request. If you are a Meta employee, you can view this in D110346303.

@lwasyl

lwasyl commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

@hick209 looks like some of the checks failed there, any idea why? Happy to add some tests and iterate on this PR if the fix is not sufficient

@hick209

hick209 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Just some internal tests. I'll work through them.
Don't worry about the rebase either, I've fixed that here internally

cortinico
cortinico approved these changes Jul 16, 2026
View reviewed changes

@cortinico cortinico left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync Bot closed this in be9edc1 Jul 16, 2026
@meta-codesync meta-codesync Bot added the Merged label Jul 16, 2026
@meta-codesync

meta-codesync Bot commented Jul 16, 2026

Copy link
Copy Markdown

@hick209 merged this pull request in be9edc1.

@lwasyl
lwasyl deleted the wasyl/461-single-param-commas branch July 17, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cortinico cortinico cortinico approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trailing comma gets removed if there is only one parameter and it is formatted to be on its own line

3 participants

@lwasyl @hick209 @cortinico