fix(template): GitLab CI — pyright libatomic + decouple maintenance jobs#75
Merged
Conversation
Two issues found running the generated GitLab CI on a real runner: - `type-check` failed because pyright's bundled Node can't start on the slim image (`libatomic.so.1: cannot open shared object file`). Install libatomic1 in that job's before_script. - `copier-update` and `renovate` (maintenance stage) were skipped whenever the test stage failed, so a failing project test suite would silently block template/dependency updates. Add `needs: []` so they run independently of the test stage. Both found via the end-to-end GitLab demo. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues found running the generated GitLab CI on a real runner during the end-to-end demo:
type-checkfails on the slim image — pyright's bundled Node can't start:libatomic.so.1: cannot open shared object file.python:*-slimlacks it. Installlibatomic1in that job'sbefore_script.copier-updateandrenovatewere skipped whenevertype-check/testfailed, so a failing project test suite would silently block template and dependency updates. Addneeds: []so they run independently.Verified: rendered
.gitlab-ci.ymlparses,type-checkinstalls libatomic1, both maintenance jobs haveneeds: [].🤖 Generated with Claude Code