feat(use-svg-overlay): multiple highlight rectangles - #111
Draft
J-Michalek wants to merge 3 commits into
Draft
J-Michalek wants to merge 3 commits into
J-Michalek wants to merge 3 commits into
Conversation
✅ Deploy Preview for eloquent-lamport-f2ffa1 canceled.
|
✅ Deploy Preview for beamish-dango-bc9c2d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
J-Michalek
marked this pull request as draft
October 29, 2024 14:54
J-Michalek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not in a mergeable state by any means as of now I just wanted to quickly create a proof of concept for this new feature of highlighting multiple elements.
Each step would be able to specify additional elements that will be highlighted by the svg path. I found that sometimes it is useful to highlight more that just one element.
Would love to get your opinion on this new feature!