Return chainable ObjectSchema from extend#302
Open
aouxwoux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run lintDescription
ObjectSchema.extend()currently returns a reduced object containing only a few schema methods. That keepsvalueOf()working, but breaks normal fluent chaining such as.prop(),.without(), or.only()after extending a schema.This changes
extend()to return the fullObjectSchemainstance created from the merged state, preserving the existing merged output while keeping the builder API chainable.Fixes #249
Notes
No docs update was needed; this restores the expected fluent behavior described by the existing API.
Tests
node --test test/ObjectSchema.test.jspnpm exec eslint lib/ObjectSchema.js test/ObjectSchema.test.jspnpm exec c8 --100 node --testpnpm exec tstyche