[#14] Optimize TypeElementCompiler for CSharp if TypeElement not have Generics#20
Merged
fembina merged 2 commits intoJun 7, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the C# TypeElementCompiler to reduce per-call work when compiling type names (especially when no generic arguments are present) by precomputing constant lengths and simplifying generic-type branching.
Changes:
- Precompute the combined
<and>length (LeftRightAngleBracketsLength) to avoid recomputing bracket lengths during compilation. - Add
checked(...)to the initialtypeLengthcomputation and refactor generic handling with ahasGenericTypesflag. - Avoid storing angle bracket constants in locals; append them directly from
CSharpLanguageConstants.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… importand to check only if value can be less to 0 and affect math operations
fembina
deleted the
14-optimize-type-element-compiler-for-csharp-if-type-element-not-have-generics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.