chore(locale)!: remove legacy cell_phone definitions - #3925
Open
matthewmayer wants to merge 7 commits into
Open
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
matthewmayer
added
the
breaking change
ST-DDT
previously approved these changes
Jun 29, 2026
ST-DDT
left a comment
ST-DDT
left a comment
Member
There was a problem hiding this comment.
I think we can merge this cleanup in v11.0.
Though we might want to also remove the other legacy data (in a separate PR). As nobody seems to be requesting them as a feature.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3925 +/- ##
==========================================
- Coverage 98.98% 98.97% -0.02%
==========================================
Files 926 893 -33
Lines 3246 3213 -33
Branches 582 582
==========================================
- Hits 3213 3180 -33
Misses 29 29
Partials 4 4
🚀 New features to boost your workflow:
|
ST-DDT
reviewed
Jun 29, 2026
Co-authored-by: ST-DDT <[email protected]>
ST-DDT
previously approved these changes
Jun 30, 2026
ST-DDT
requested changes
Aug 18, 2026
ST-DDT
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend to use
faker.phone.number({style:"mobile"})instead.