feat: show elapsed time per step in runner output#17
feat: show elapsed time per step in runner output#17Kanneboinashivakumar wants to merge 2 commits into
Conversation
|
Hi @faisalishfaq2005, could you please take a look at this PR and approve the pending workflow when you get a chance so the checks can run? I've tested everything locally and it should be ready for review. Thank you! |
|
Thanks for this , the core change in src/commands/run.ts and src/core/runner.ts is exactly right and does what the issue asked for; I checked it out and typecheck/build/tests all pass. Before merging though, could you trim the diff down to just those two files? The commit also pulls in |
|
Hi @faisalishfaq2005, thanks for the review! I've addressed all the requested changes: Removed the local .loopflow artifacts and reverted package-lock.json. Validation completed successfully: Please take another look when you have a chance. Thanks again! |
|
Hi @faisalishfaq2005, just a quick follow-up on this PR whenever you get a chance. I've addressed all the requested changes (artifact cleanup, style fixes, and tests passing), and the PR should now be aligned with the review feedback. It looks like the only remaining item is the workflow approval. Whenever you're available to take another look or merge, I'd really appreciate it. Thanks again for your time reviewing this! |
|
Just a friendly follow-up on this PR whenever you have some time. As requested, I removed the local artifacts, applied the style fixes, and verified that the PR now contains only the intended changes to Whenever you're available, I'd appreciate another look. Thanks again for your time and feedback! |
Closes #6
What problem does this solve?
Currently, the runner output only shows the cost of each step:
✓ done · $0.31
However,
ClaudeResultalready contains adurationMsfield with the elapsed time. Users want visibility into how long each step takes, not just the cost.Changes Made
This PR adds duration display to the runner output by:
Ensuring
durationMsis carried throughStepRun(src/core/runner.ts)Propagating
durationMsfromClaudeResultstepRunasdurationMs: result.durationMsUpdating
onStepFinishreporter (src/commands/run.ts)8.2s)📊 Before & After
Before:
✓ done · $0.31
✗ ERROR · $0.00
After:
✓ done · $0.31 · 8.2s
✗ ERROR · $0.00 · 0.2s
Testing
npm run buildpassesnode dist/cli.js run test-and-fix --dry-run
Checklist
npm run buildpassesnpm run typecheckpasses