Adjust conversion logic to assume no chroma for undefined hues#517
Draft
facelessuser wants to merge 7 commits into
Draft
Adjust conversion logic to assume no chroma for undefined hues#517facelessuser wants to merge 7 commits into
facelessuser wants to merge 7 commits into
Conversation
gir-bot
added
S: needs-review
Owner
Author
|
It has not been decided whether we will do this, but I wanted to capture a potential resolution if we do go down this path. |
facelessuser
force-pushed
the
feature/hue-null-chroma-zero
branch
from
June 26, 2026 17:27
c9b2986 to
26e5c4f
Compare
Colors are currently normalized into defined values then passed through a chain of color conversions until the color arrives at the target space. To avoid having to pass undefined values to every space in the chain requiring each space to resolve the undefined values, this approach keeps this logic at the top level of the convert function and applies the chroma hue normalization as the first, initial step before iterating the conversions in the color chain. This keeps the logic generic and requires no modification of every color space. Resolves #484
facelessuser
force-pushed
the
feature/hue-null-chroma-zero
branch
from
July 18, 2026 01:33
26e5c4f to
066027e
Compare
gir-bot
added
C: hsl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colors are currently normalized into defined values then passed through a chain of color conversions until the color arrives at the target space. To avoid having to pass undefined values to every space in the chain requiring each space to resolve the undefined values, this approach keeps this logic at the top level of the convert function and applies the chroma hue normalization as the first, initial step before iterating the conversions in the color chain. This keeps the logic generic and requires no modification of every color space.
Resolves #484