Rust language edition and version related refactorings#489
Open
SaelKimberly wants to merge 20 commits into
Open
Rust language edition and version related refactorings#489SaelKimberly wants to merge 20 commits into
SaelKimberly wants to merge 20 commits into
Conversation
…orkspace level. Manual fix edition-related compilation errors.
…dition-related compilation errors fixed)
…dition-related compilation errors fixed)
Author
|
Oh, got it. I missed the code related to the windows platform. I'll fix it tomorrow. |
Author
|
Just fixed. How I missed that?( Also, add some commits, which, I think, could easily be reverted, if have a blocking issues in them. Updated "async-ffi" dep, add "rust-toolchain.toml" file, based on existing github CI builds, and set "resolver" to "3" (preventing MSRV-related build errors). Other changes are clippy lint fixes or cosmetic changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I've refactored the Rust code related to language versions and editions, primarily using
cargo fix --edition,cargo fix,cargo fmt, andcargo clippy --fix. Some parts of the code were manually refactored to eliminate edition-related incompatibilities. I also removed the dependency onlazy-static, replacing it with LazyLock (from the standard library).Furthermore, I've locked the Rust edition and version at the workspace level for easier maintenance.
All tests seem to work as expected, and the CLI binary compiles successfully.
This is a truly great project, and I hope my contribution is helpful!