Skip to content

Staging #6477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hamzah-2002 wants to merge 2 commits into from
Closed

Staging #6477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db92d43
docs: update Contributing.md to clarify repo captain permissions
bjohansebas Feb 22, 2025
ed9ed44
Merge pull request #1 from Hamzah-2002/captain-perm
Hamzah-2002 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ active member steps down.
The Express TC can designate captains for individual projects/repos in the
organizations. These captains are responsible for being the primary
day-to-day maintainers of the repo on a technical and community front.
Repo captains are empowered with repo ownership and package publication rights.
Repo captains are empowered with maintain access and package publication rights.

@wesleytodd wesleytodd Apr 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a legitimate change to make, but we recently moved these docs to the discussions repo. If you want to try and land this, can you make this PR there?

We might also want to say "Repo captians are empowered to maintain the project with the repo maintain role and pacakge publication rights."?

@bjohansebas bjohansebas Apr 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there's already a PR open in this repository for the same thing, but yes please, open this PR in the discussions repo.

@wesleytodd wesleytodd Apr 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean this one? expressjs/discussions#353

I don't see one that updates this language and checked that it was not changed in master.

@bjohansebas bjohansebas Apr 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6357

@wesleytodd wesleytodd Apr 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I think we can just close this as duplicate then, and either you or @Hamzah-2002 can re-open it.

When there are conflicts, especially on topics that effect the Express project
at large, captains are responsible to raise it up to the TC and drive
those conflicts to resolution. Captains are also responsible for making sure
Expand Down