fix: add feedbackBatchSize to plugin config schema#43
Open
Pratimakumari8 wants to merge 2 commits into
Open
Conversation
feedbackBatchSize was being silently stripped because the schema did not declare it as a known property. Adding it here allows the field to pass through to the plugin correctly.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c5a3960b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Author
|
Hi @kfallah — happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
feedbackBatchSizeconfig key was being silently strippedby OpenClaw before reaching the claas-feedback plugin.
This happened because
openclaw.plugin.jsonuses a strictschema that discards any keys not explicitly declared in
properties. SincefeedbackBatchSizewas missing from theschema, setting
feedbackBatchSize: 1in the config had noeffect — the plugin always used its default batch size.
Fix
Added
feedbackBatchSizeas a declared property in theconfigSchema, with type
integerandminimum: 1toensure only positive whole numbers are accepted.
Related
Closes #20