Skip to content

Sync nth prime#956

Merged
mk-mxp merged 6 commits intoexercism:mainfrom
Narkunan:sync-nth-prime
May 8, 2026
Merged

Sync nth prime#956
mk-mxp merged 6 commits intoexercism:mainfrom
Narkunan:sync-nth-prime

Conversation

@Narkunan
Copy link
Copy Markdown
Contributor

@Narkunan Narkunan commented Apr 28, 2026

fix issue #924

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 28, 2026

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Narkunan
Narkunan commented Apr 28, 2026
View reviewed changes
Comment thread exercises/practice/nth-prime/NthPrimeTest.php
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Apr 28, 2026
@Narkunan
Copy link
Copy Markdown
Contributor Author

Narkunan commented Apr 29, 2026

@mk-mxp Ready for your review

mk-mxp
mk-mxp reviewed May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the late response, private and business life sometimes is too busy to volunteer here. Thanks for your contribution!

Comment thread exercises/practice/nth-prime/NthPrimeTest.php Outdated
@Narkunan
Copy link
Copy Markdown
Contributor Author

Narkunan commented May 8, 2026

@mk-mxp Ready for your review.Thanks!

mk-mxp
mk-mxp approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution!

@mk-mxp mk-mxp merged commit f197c51 into exercism:main May 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@Narkunan Narkunan

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Narkunan @mk-mxp