flower-field replaces minesweeper#1289
Merged
Merged
Conversation
keiravillekode
force-pushed
the
flower-field
branch
from
eebe29f to
d86688a
Compare
Member
|
+cc @exercism/haskell |
MatthijsBlom
requested changes
May 27, 2026
MatthijsBlom
left a comment
MatthijsBlom
left a comment
Contributor
There was a problem hiding this comment.
Inclusion of this exercise easily has my approval, but I feel the unrelated changes to .github/workflows/tests.yml and config.json belong in a separate PR.
keiravillekode
force-pushed
the
flower-field
branch
from
a5d6766 to
b3ca346
Compare
Contributor
Author
|
I have removed those unrelated changes |
MatthijsBlom
requested changes
May 27, 2026
MatthijsBlom
left a comment
MatthijsBlom
left a comment
Contributor
There was a problem hiding this comment.
It looks like you accidentally undid some intended changes. I have marked these with suggestions.
Comment on lines
+25
to
+27
| "example": [ | ||
| ".meta/examples/success-standard/src/FlowerField.hs" | ||
| ], |
Contributor
There was a problem hiding this comment.
Inclusion of package.yaml, required by automatic tests.
Suggested change
| "example": [ | |
| ".meta/examples/success-standard/src/FlowerField.hs" | |
| ], | |
| "example": [ | |
| ".meta/examples/success-standard/src/FlowerField.hs", | |
| ".meta/examples/success-standard/package.yaml" | |
| ], |
Comment on lines
336
to
344
| { | ||
| "slug": "minesweeper", | ||
| "name": "Minesweeper", | ||
| "uuid": "821f2081-dfc2-40c6-8e12-2907daa04416", | ||
| "practices": [], | ||
| "prerequisites": [], | ||
| "difficulty": 7, | ||
| "topics": [] | ||
| }, |
Contributor
There was a problem hiding this comment.
Deprecation of Minesweeper:
Suggested change
| { | |
| "slug": "minesweeper", | |
| "name": "Minesweeper", | |
| "uuid": "821f2081-dfc2-40c6-8e12-2907daa04416", | |
| "practices": [], | |
| "prerequisites": [], | |
| "difficulty": 7, | |
| "topics": [], | |
| "status": "deprecated" | |
| }, |
keiravillekode
force-pushed
the
flower-field
branch
from
b3ca346 to
613ac2f
Compare
keiravillekode
force-pushed
the
flower-field
branch
from
613ac2f to
d03fb0f
Compare
MatthijsBlom
approved these changes
May 27, 2026
Contributor
Author
|
This is ready for a Haskell maintainer to merge. (I don't have merge privileges.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update actions/cache in
.github/workflows/tests.ymlformat config.json using
bin/configlet fmt