Skip to content

Align instruction exemples with assert_output expected in secret handshake exercice#775

Closed
resu-xuniL wants to merge 1 commit into
exercism:mainfrom
resu-xuniL:secret-handcheck-align-instructions
Closed

Align instruction exemples with assert_output expected in secret handshake exercice#775
resu-xuniL wants to merge 1 commit into
exercism:mainfrom
resu-xuniL:secret-handcheck-align-instructions

Conversation

@resu-xuniL
Copy link
Copy Markdown

In this exercice, there's a difference between the output expected (wink,double blink) and the exemples given in the instructions.md file (wink, jump) -> extra space after comma.

This PR is to align them.

I choose to edit the instructions.md file so the tests have not to be run again.

If the intent was that the outputs should have that extra space after comma, the secret_handshake.bats file needs to be modified but in that case, all the tests must be run again as the assert_output would no longer be the same.

[no important files changed]

Reviewer Resources:

Track Policies

@IsaacG
Copy link
Copy Markdown
Member

IsaacG commented May 31, 2026

https://exercism.org/docs/community/being-a-good-community-member/suggesting-exercise-improvements

That markdown file is synced from an upstream repo. We generally do not accept manual changes to that file.

@IsaacG
Copy link
Copy Markdown
Member

IsaacG commented May 31, 2026

Given the limitations of using STDOUT for this track, the tests tend to be a touch wonky. The student is expected to use the tests to discover the exact requirements. I'm not sure we want to change the tests here, either. At most, maybe an append file for the instructions. I'd love to get the thoughts of the other maintainers.

@glennj
Copy link
Copy Markdown
Contributor

glennj commented Jun 1, 2026

I'm inclined to leave it as-is. Students may see the tests fail, spot the difference, and update their code.

@IsaacG IsaacG closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants