Align instruction exemples with assert_output expected in secret handshake exercice#775
Closed
resu-xuniL wants to merge 1 commit into
Closed
Align instruction exemples with assert_output expected in secret handshake exercice#775resu-xuniL wants to merge 1 commit into
assert_output expected in secret handshake exercice#775resu-xuniL wants to merge 1 commit into
Conversation
Member
|
https://exercism.org/docs/community/being-a-good-community-member/suggesting-exercise-improvements That markdown file is synced from an upstream repo. We generally do not accept manual changes to that file. |
Member
|
Given the limitations of using STDOUT for this track, the tests tend to be a touch wonky. The student is expected to use the tests to discover the exact requirements. I'm not sure we want to change the tests here, either. At most, maybe an append file for the instructions. I'd love to get the thoughts of the other maintainers. |
Contributor
|
I'm inclined to leave it as-is. Students may see the tests fail, spot the difference, and update their code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this exercice, there's a difference between the output expected (
wink,double blink) and the exemples given in theinstructions.mdfile (wink, jump) -> extra space after comma.This PR is to align them.
I choose to edit the
instructions.mdfile so the tests have not to be run again.If the intent was that the outputs should have that extra space after comma, the
secret_handshake.batsfile needs to be modified but in that case, all the tests must be run again as theassert_outputwould no longer be the same.[no important files changed]
Reviewer Resources:
Track Policies