Skip to content

Euler angles [incomplete]#57

Open
mcclure wants to merge 1 commit into
excessive:masterfrom
mcclure:euler-quat
Open

Euler angles [incomplete]#57
mcclure wants to merge 1 commit into
excessive:masterfrom
mcclure:euler-quat

Conversation

@mcclure

@mcclure mcclure commented May 4, 2020

Copy link
Copy Markdown
Collaborator

Sometime in January I needed euler angles so I threw together a quat.to_euler_angles function (and a quat.to_euler_angles_unpack function).

I would like to submit it back upstream but I think first this PR needs:

  • A from_euler_angles function
  • Tests
  • Some kind of better documentation, for example explaining what axis standard this to_euler_angles function uses. What standard does it use ?? … I'm not sure.

@coveralls

coveralls commented May 4, 2020

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 80.197% when pulling ae4601f on mcclure:euler-quat into ddb80f4 on excessive:master.

@mcclure

mcclure commented Sep 2, 2021

Copy link
Copy Markdown
Collaborator Author

I've been testing this in practice and I don't think it works.

Will post more about this later...

@FatalistError

Copy link
Copy Markdown

(he didn't post more about this later)

@mcclure

mcclure commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator Author

I don't remember anymore what I was going to post about it later :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants