387 owewokswidgetwithtaskstack provide api to cancel a task 3 add example#411
Merged
woutdenolf merged 4 commits intoJul 17, 2026
Conversation
payno
reviewed
Jul 17, 2026
| @@ -1,2 +1,3 @@ | |||
| from .EwoksExecutor import EwoksExecutor # noqa F401 | |||
| from .EwoksExecutor import SubmitPolicy # noqa F401 | |||
| task.execute() | ||
| finally: | ||
| done.set() | ||
| self._abort_event.set() |
Member
There was a problem hiding this comment.
I don't see why the abort should always be set. Should it be more upper (line 54 and replacing line 50?)
Member
Author
There was a problem hiding this comment.
this is the stop the _watch_abort thread which is waiting on self._abort_event.wait(). See above, it has a comment.
payno
approved these changes
Jul 17, 2026
woutdenolf
merged commit Jul 17, 2026
273197f
into
387-owewokswidgetwithtaskstack-provide-api-to-cancel-a-task-3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add fix and example script