-
Notifications
You must be signed in to change notification settings - Fork 0
Remove cli #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove cli #12
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,36 @@ | ||
| # This file is intentionally left blank. | ||
| import random | ||
| from pathlib import Path | ||
|
|
||
| from ewokscore.graph import TaskGraph | ||
| from ewokscore.graph.inputs import _get_all_node_inputs | ||
| from ewokscore.graph.inputs import _get_all_task_output_names | ||
|
|
||
| from .svg import SvgBackground | ||
| from .svg import SvgCanvas | ||
| from .svg import SvgTask | ||
|
|
||
|
|
||
| def graph_to_svg(graph: TaskGraph, output_path: str | Path): | ||
| canvas_width = 500 | ||
| canvas_height = 500 | ||
|
|
||
| canvas = SvgCanvas(width=canvas_width, height=canvas_height) | ||
| svg_background = SvgBackground(canvas_width, canvas_height) | ||
| canvas.add_element(svg_background) | ||
|
|
||
| for node_id, node_attrs in graph.graph.nodes.items(): | ||
| node_inputs = _get_all_node_inputs(node_id, node_attrs) | ||
| node_outputs = _get_all_task_output_names( | ||
| node_attrs["task_type"], node_attrs["task_identifier"] | ||
| ) | ||
| svg_task = SvgTask( | ||
| task_name=node_id, | ||
| input_names=[n.name for n in node_inputs], | ||
| output_names=node_outputs, | ||
| ) | ||
|
|
||
| svg_task.translate(x=random.randint(5, 400), y=random.randint(5, 400)) | ||
|
|
||
| canvas.add_element(svg_task) | ||
|
|
||
| canvas.draw(output_path) | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| from pathlib import Path | ||
| from xml.etree import ElementTree | ||
|
|
||
| import pytest | ||
| from ewokscore import load_graph | ||
| from ewokscore.tests.examples.graphs import get_graph | ||
| from ewokscore.tests.examples.graphs import graph_names | ||
|
|
||
| from ewoksdraw import graph_to_svg | ||
|
|
||
|
|
||
| def _get_svg_groups(output_path: Path): | ||
| tree = ElementTree.parse(output_path) | ||
| root = tree.getroot() | ||
| return [child for child in root if child.tag.endswith("g")] | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("graph_name", graph_names()) | ||
| def test_groups_are_matching_nodes(graph_name, tmp_path: Path): | ||
| output_path = tmp_path / "test.svg" | ||
|
|
||
| graph, _ = get_graph(graph_name) | ||
| ewoksgraph = load_graph(graph) | ||
|
|
||
| graph_to_svg(ewoksgraph, output_path) | ||
|
|
||
| assert output_path.is_file() | ||
|
|
||
| groups = _get_svg_groups(output_path) | ||
| for group, node_name in zip(groups, ewoksgraph.graph.nodes.keys()): | ||
| assert group[0].text == node_name |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the SvgCanvas can also generate SVG dict and string representations, not just files. Not sure we should already anticipate this usage.