Show percent operator only for number variables#73
Merged
Conversation
The percent operator was offered for string variables in the operator dropdown, but it only makes sense for integer values. Remove it from the STRING type's operator list so it is available only for NUMBER.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Removed
Operator.PERCENTfrom the STRING type's operator list inui/src/Dashboard/constants.js, so the percent operator is now offered only for NUMBER variables.Why
The percent operator only makes sense for integer values, but the operator dropdown offered it for string variables as well. Since all operator dropdowns (Check, ValueCheck, Flag, Value) build their options from the single
TYPESmap, this one-line change covers the whole UI.Notes for reviewers
Existing checks already saved with percent on a string variable keep working server-side, but their operator dropdown will display the raw value
7instead of the "percent" label since the option is no longer in the list.