Skip to content

Add 'exclude-newer' configuration to uv tool in pyproject.toml files #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dashing-Nelson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add 'exclude-newer' configuration to uv tool in pyproject.toml files #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions argo-kedro/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,3 +64,6 @@ include = ["argo_kedro*"]

[tool.setuptools.package-data]
argo_kedro = ["**/*.tmpl", "**/*.yml", "**/*.dockerignore", "**/*.Dockerfile"]

[tool.uv]
exclude-newer = "1 week"
3 changes: 3 additions & 0 deletions argo-test/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,6 @@ ignore = [

[tool.kedro_telemetry]
project_id = "ac60f8a981ee4ae8a2a0d6d8d7d28ee1"

[tool.uv]
exclude-newer = "1 week"
Comment on lines +89 to +91

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file already defines [tool.uv.sources] earlier, which creates the tool.uv table. Adding [tool.uv] later can be invalid TOML (parent table declared after child) and may fail parsing in strict TOML parsers. Reorder the sections so [tool.uv] appears before [tool.uv.sources] (or avoid reopening tool.uv).

Copilot uses AI. Check for mistakes.
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ requires-python = "==3.12.*"
[tool.uv.workspace]
members = ["argo-kedro", "argo-test"]

[tool.uv]
exclude-newer = "1 week"
Comment on lines 7 to +11

Copilot AI Apr 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In TOML, declaring a parent table after a child table is invalid in strict parsers. Since [tool.uv.workspace] already creates the tool.uv table, adding a later [tool.uv] header can cause the file to fail to parse (e.g., with Python tomllib) and break tooling that reads pyproject.toml. Move [tool.uv] (and exclude-newer) above [tool.uv.workspace], or place exclude-newer in a way that doesn’t reopen the parent table.

Suggested change
[tool.uv.workspace]
members = ["argo-kedro", "argo-test"]
[tool.uv]
exclude-newer = "1 week"
[tool.uv]
exclude-newer = "1 week"
[tool.uv.workspace]
members = ["argo-kedro", "argo-test"]

Copilot uses AI. Check for mistakes.
Loading