fix(catalog): add manifest path fields + trim over-long marketer skill why#1
Merged
Merged
Conversation
…l why The validate workflow requires every manifest.json template entry to have a `path` (it checks the dir exists on disk); the per-template-tree expansion added manifestPath/soulPath/etc. but not `path`, so all 8 entries failed. Add `path: templates/<slug>` to each entry. Also trim the two starter-marketer recommended skill `why` fields that exceeded the 200-char cap in schema/skills.schema.json. Verified locally with the workflow's validator: "All catalog files valid." Co-Authored-By: Claude Opus 4.7 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mainis red on thevalidateworkflow (run). Two failures:manifest entry <slug> missing path(all 8 templates). The validator requires everymanifest.jsonentry to have apathand checks the dir exists on disk. The per-template-tree expansion addedmanifestPath/soulPath/etc. but notpath. → Added"path": "templates/<slug>"to each entry.skills.yml schema errors for starter-marketer: ...why must NOT have more than 200 characters(bothrecommendedentries). → Trimmed the twowhystrings under the 200-char cap fromschema/skills.schema.json, keeping the meaning.Verification
Ran the workflow's validator locally against the branch:
Minimal diff — 8
pathlines added tomanifest.json(inlinetagsarrays untouched), 2whyfields shortened. No schema or workflow changes.🤖 Generated with Claude Code