fix: avoid blocking I/O in event loop when reading manifest version#30
Merged
Conversation
Offload the synchronous manifest.json read to the executor via hass.async_add_executor_job, since _add_resource runs on the event loop and synchronous file I/O there blocks the MainThread. Fixes #29 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
🎉 This PR is included in version 1.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
frontend.pyreadmanifest.jsonwith a synchronousopen()call directly inside_add_resource, an async coroutine that runs on the Home Assistant event loop. Home Assistant's blocking-call detector flags this and can crash/boot-loop on startup.Fixed by offloading the synchronous read to the executor via
hass.async_add_executor_job(_get_version)instead of calling_get_version()directly on the event loop.Also added
__pycache__/and*.pycto.gitignore.Fixes #29
Type of change
Checklist
npm run lintpassesnpm run typecheckpassesnpm run testpassesnpm run format:checkpassesfeat:,fix:)Generated by Claude Code