Remove inaccessible "express" feature#2018
Conversation
jshearer
left a comment
There was a problem hiding this comment.
Happy to merge as is, deleting code/cleaning up is always great. That being said, Claude found a few dangling threads that could net even more deletions!
Workflow store still carries express-only state
customerId, redirectUrl, and their setters (setCustomerId, setRedirectUrl) have zero remaining callers after this commit. ExpressWorkflowGuard was the only writer for both.
ui/src/stores/Workflow/types.ts
Lines 19 to 25 in 6d0f8f5
ui/src/stores/Workflow/Store.ts
Lines 76 to 94 in 6d0f8f5
That leaves an unreachable branch in useEntityWorkflowHelpers
Since redirectUrl can never be set again, externalRedirect in HeaderLogs.tsx is always false, so the window.location.href branch in exit() can't fire for any surviving flow. HeaderLogs is the only caller that ever passes external=true.
ui/src/components/shared/Entity/HeaderLogs.tsx
Lines 23 to 31 in 6d0f8f5
ui/src/components/shared/Entity/hooks/useEntityWorkflowHelpers.ts
Lines 87 to 109 in 6d0f8f5
docs/STATE.md still documents the flow
Lines 100 to 107 in 6d0f8f5
Orphaned translation string
expressFlowIntegration had exactly one consumer, PoweredByEstuaryWatermark, which this commit deletes.
ui/src/lang/en-US/CommonMessages.ts
Line 6 in 6d0f8f5
customerId, redirectUrl, and their setters on the Workflow store had no remaining callers after ExpressWorkflowGuard was deleted. That in turn left the external-redirect branch in useEntityWorkflowHelpers' exit() unreachable, along with the closeCtaKey plumbing and cta.exit string that only existed to drive it. Also drops the orphaned expressFlowIntegration string and the docs/STATE.md mention of the express_capture_create flow.
✅ Code HealthRemoves 49 Unused files
|
I anticipate revisiting this feature, and referencing this work, but for now we can remove a lot dead code