notifications: remove stale alert_notifications snapshot files#3079
Open
jwhartley wants to merge 1 commit into
Open
notifications: remove stale alert_notifications snapshot files#3079jwhartley wants to merge 1 commit into
jwhartley wants to merge 1 commit into
Conversation
The crate was renamed from alert_notifications to notifications, so insta now writes and reads snapshots under the notifications__tests__ prefix. The 16 alert_notifications__tests__*.snap files are dead duplicates that no current test references. Verified: cargo test --manifest-path crates/notifications/Cargo.toml passes (25 tests) with them removed.
Contributor
Author
|
should be a quick one @jshearer, just some cleanup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the 16
crates/notifications/src/snapshots/alert_notifications__tests__*.snapfiles.Why
The crate was renamed from
alert_notificationstonotifications(seecrates/notifications/Cargo.toml). insta names snapshot files{crate}__{module}__{name}.snap, so it now writes and reads under thenotifications__tests__prefix. Every test callsinsta::assert_snapshot!("<explicit_name>", ...), and the live set lives undernotifications__tests__. Thealert_notifications__tests__*files are dead duplicates left over from before the rename; no current test can reference them.Verification
git rmof the 16 files: 25 passed (a missing referenced snapshot would have failed the run).The 19 live
notifications__tests__*.snapfiles are untouched.