fix: use DragStartBehavior.down for free text-drag selection#666
Closed
goccd wants to merge 1 commit into
Closed
Conversation
The text selection GestureDetector used the default DragStartBehavior.start, so onPanStart reported the post-slop position (~kTouchSlop, 18px). Free text-drag selection therefore began 1-2 characters after the touch-down on touch devices (notably iPad/tablets), skipping the first character(s). Setting dragStartBehavior: DragStartBehavior.down makes onPanStart report the original pointer-down position, so selection starts exactly where the user pressed. Refs: espresso3389#665
goccd
force-pushed
the
fix/drag-start-anchor
branch
from
72f55e6 to
289b269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #665
The text selection
GestureDetectorused the defaultDragStartBehavior.start,so
onPanStartreported the post-slop position (~kTouchSlop, 18px). Freetext-drag selection therefore began 1-2 characters after the touch-down on
touch devices (notably iPad/tablets), skipping the first character(s).
Setting
dragStartBehavior: DragStartBehavior.downmakesonPanStartreportthe original pointer-down position, so selection starts exactly where the
user pressed.
Changes
packages/pdfrx/lib/src/widgets/pdf_viewer.dart: setdragStartBehavior: DragStartBehavior.downon the free text-drag selectionGestureDetector.