Skip to content

Add common useless serials and compare in lowercase to catch differently cased versions#13

Open
JuanIrache wants to merge 1 commit into
es128:masterfrom
JuanIrache:patch-1
Open

Add common useless serials and compare in lowercase to catch differently cased versions#13
JuanIrache wants to merge 1 commit into
es128:masterfrom
JuanIrache:patch-1

Conversation

@JuanIrache

Copy link
Copy Markdown

Addresses #12

@chetbox

chetbox commented Aug 20, 2021

Copy link
Copy Markdown

On the 120 machines of our users we have seen all of these serial numbers come up but no others that are worth adding. We have seen uppercase/lowercase variations of some too so that case insensitive check is very helpful.

I think this is a really worthwhile improvement. @es128 can we get this merged and published?

@chetbox

chetbox commented Aug 20, 2021

Copy link
Copy Markdown

I've just spotted that Coreboot on a StarLabs Mk IV (My dev machine!) returns a serial number of 123456789. Is it worth adding that to the list?

Edit: Although the UUID is not very useful either!

System Information
        Manufacturer: Star Labs
        Product Name: LabTop
        Version: 1.0
        Serial Number: 123456789
        UUID: Not Settable

@JuanIrache

Copy link
Copy Markdown
Author

Two more serial numbers reported by multiple machines:
03000200-0400-0500-0006-000700080009
FFFFFFFF-FFFF-FFFF-FFFF-FFFFFFFFFFFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants