Ernestl/seclog part5#6
Open
ernestl wants to merge 3 commits into
Open
Conversation
Owner
Author
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
Owner
Author
|
https://github.com/cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
|
Fri Jun 5 16:07:08 UTC 2026 No spread failures reported |
Owner
Author
|
https://github.com/cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
ernestl
force-pushed
the
ernestl/seclog-part5
branch
5 times, most recently
from
800b872 to
660ef64
Compare
Add Peer, Endpoint, AuthzChecks types and LogAdminActivity / LogUnauthorizedAccess for security audit events. Extend Reason with HTTP code and semantic kind fields for structured error logging. Co-authored-by: Cursor <[email protected]>
Return accessLevel from CheckAccess and emit authz_admin/authz_fail only when authorization checks were evaluated. Skip audit on dispatch-only byActionAccess failures via accessLevelNotEvaluated. Populate authz_checks during checkAccess, derive audit reasons from apiError, and share JSON action body parsing between audit logging and tracing. Co-authored-by: Cursor <[email protected]>
Verify admin API authorization events are emitted for successful and rejected calls over snapd.socket. Co-authored-by: Cursor <[email protected]>
ernestl
force-pushed
the
ernestl/seclog-part5
branch
from
660ef64 to
616cbc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?