[pull] main from CPAtoCybersecurity:main - #35
Merged
Conversation
The trend chart embedded in the audit report is captured live from the dashboard, so it already renders the new FUNCTION_LINE_COLORS. The legend beneath it was hand-written against the old palette, leaving the exported report showing a chart and a legend in different colors.
The wheel hues are tuned for a filled wheel, not 2px strokes: on white, GOVERN sat at 2.02:1 and RECOVER at 2.12:1, below the 3:1 floor for graphical objects, and both were regressions from the colors they replaced. Darkening for white alone would have failed the dark-mode chart, and the audit report captures that chart onto white whatever theme is active, so one set has to clear both. These hold the same hue and saturation at the lightness where every function clears 3.8:1 on white and on #1f2937. Also aligns the dead BADGE_COLORS.function table and three stale comments that still described the pre-wheel palette.
Match CSF function colors to the NIST CSF 2.0 wheel; use SC shield in header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )