tui: show all slash commands in / picker; add scroll indicators to @ picker (closes #356)#357
Merged
Merged
Conversation
…picker (closes #356) The slash-command popup reused the @-file picker's 8-row scroll window with no indicator, so a bare `/` showed clear…model and silently hid resume, session, tools, tree, and usage — it looked like the autocomplete was missing commands. - slash picker: no scroll window — the command set is small and bounded, so every match is always visible. - @-file picker: keeps its 8-row window (workspaces are unbounded) but now renders `↑ N more` / `↓ N more` lines when the window clips. - both pickers expose popupRows() and layout() uses it, so the popup height math can't drift from what render emits. Co-Authored-By: Claude Fable 5 <[email protected]>
glue-reviewNo concerns — LGTM. Refactors the TUI pickers to ensure 🤖 Posted by glue-review. |
erain
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Typing
/opened the command picker windowed to 8 rows (the @-file picker's constant) with no scroll indicator — alphabetically that showedclear…modeland silently hidresume,session,tools,tree,usage, making the autocomplete look incomplete.Changes
/now always lists every command.↑ N more/↓ N moreindicators. It keeps its 8-row window (workspaces are unbounded), but clipped matches are now discoverable.popupRows()on both pickers, used bylayout()— the popup height math is derived from the same code path as rendering, so they can't drift.Tests
TestSlashPickerShowsEveryCommandOnBareSlash— pins every spec visible, no indicator ever.TestAtPickerWindowIndicators— top/mid/bottom cursor positions show the rightN morelines, andpopupRows()matches; no indicators when matches fit.gofmtclean,go vetclean, fullgo test ./...passes.🤖 Generated with Claude Code