Use pybind for subsidence bindings#1214
Merged
Merged
Conversation
MagnusSletten
force-pushed
the
rd_subsidence
branch
2 times, most recently
from
c5ab0e2 to
5c81735
Compare
MagnusSletten
force-pushed
the
rd_subsidence
branch
from
5c81735 to
80908d1
Compare
If base_survey is None, this check is now performed by pybind.
eivindjahren
force-pushed
the
rd_subsidence
branch
from
24e3130 to
f8d280a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #1205
Approach
Adds a new pybind module for subsidence and updates
rd_subsidence.pyto use it instead of defining the native bindings throughResdataPrototype.