chore(drawer.tsx): replace <header> and <footer> with <div>#662
Merged
Conversation
Collaborator
|
@maryxan Description might need some refining |
xanderantoniadis
approved these changes
Jun 11, 2026
ThrasyvoulosKafasis
approved these changes
Jun 12, 2026
|
🎉 This PR is included in version 6.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes recurring accessibility violations in overlay components where portaled semantic
<header>and<footer>elements were exposed as duplicate page landmarks (bannerandcontentinfo) to assistive technologies.Changes
This PR affects the Drawer and Modal components by:
<header>and<footer>elements in overlay chrome with styled<div>elements to prevent duplicate landmark announcements.aria-labelledby="drawer-title"to the Drawer dialog when a header/title is present, ensuring the dialog is properly labeled for assistive technologies.Fixes
bannerandcontentinfolandmarks in portaled overlays.aria-labelledby.