Remove Storybook files from gnosis-vue directory branch (PR #629 cleanup)#631
Merged
marios-tsigkas merged 2 commits intoMar 10, 2026
Conversation
Co-authored-by: marios-tsigkas <[email protected]>
Copilot
AI
changed the title
[WIP] Remove Storybook-related files from gnosis-vue branch
Remove Storybook files from gnosis-vue directory branch (PR #629 cleanup)
Mar 10, 2026
marios-tsigkas
marked this pull request as ready for review
March 10, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Strips all Storybook-related additions from
copilot/add-gnosis-vue-directoryso PR #629 stays focused on the core gnosis-vue wrapper. The Storybook config, Vue stories, shared.meta.tsfiles, and relatedpackage.jsonchanges belong in PR #630 (copilot/add-shared-meta-files).Changes
Deleted:
gnosis-vue/.storybook/preview.tsgnosis-vue/src/stories/— all 7 Vue story files (Button,Input,Alert,Tag,Text,Chip,Toast)src/components/Button/Button.meta.ts,Alert.meta.ts,Tag.meta.ts,Text.meta.tsReverted:
gnosis-vue/package.json— removed Storybook devDependencies (@storybook/vue3-vite, addons,storybook) andstorybook/build:storybookscriptsKept (original PR #629 scope):
gnosis-vue/.storybook/main.tsgnosis-vue/src/index.ts,src/utils/withVModel.tsgnosis-vue/package.jsoncore deps,tsconfig.json,vite.config.tsFixes
Original prompt
Summary
Remove all Storybook-related files from the
copilot/add-gnosis-vue-directorybranch so that PR #629 stays focused on the core gnosis-vue wrapper only. The Storybook stuff belongs in PR #630 (copilot/add-shared-meta-files).IMPORTANT: Do NOT create a new branch or a new PR. Push changes directly to the existing
copilot/add-gnosis-vue-directorybranch.Files to DELETE from
copilot/add-gnosis-vue-directoryVue Storybook config
gnosis-vue/.storybook/preview.tsVue story files
gnosis-vue/src/stories/Button.stories.tsgnosis-vue/src/stories/Input.stories.tsgnosis-vue/src/stories/Alert.stories.tsgnosis-vue/src/stories/Tag.stories.tsgnosis-vue/src/stories/Text.stories.tsgnosis-vue/src/stories/Chip.stories.tsgnosis-vue/src/stories/Toast.stories.tsShared meta files (these belong in PR #630)
src/components/Button/Button.meta.tssrc/components/Alert/Alert.meta.tssrc/components/Tag/Tag.meta.tssrc/components/Text/Text.meta.tsRevert
gnosis-vue/package.jsonReplace the current
gnosis-vue/package.json(blob sha:89c193eeeaff05b1f07d0a4bd5320c5150312a8e) with the original version that does NOT have Storybook devDependencies or scripts. The file should be:{ "name": "@epignosis_llc/gnosis-vue", "version": "1.0.0", "type": "module", "description": "Vue 3 wrapper for the Epignosis Gnosis design system", "main": "dist/gnosis-vue.umd.cjs", "module": "dist/gnosis-vue.js", "types": "dist/types/index.d.ts", "exports": { ".": { "types": "./dist/types/index.d.ts", "import": "./dist/gnosis-vue.js", "require": "./dist/gnosis-vue.umd.cjs" } }, "files": ["dist"], "peerDependencies": { "vue": "^3.3.0", "react": ">=18.0.0", "react-dom": ">=18.0.0" }, "dependencies": { "@epignosis_llc/gnosis": "^6.6.3", "veaury": "^2.6.0" }, "devDependencies": { "@vitejs/plugin-vue": "^5.0.0", "@vitejs/plugin-react": "^4.0.0", "vite": "^5.0.0", "vite-plugin-dts": "^3.0.0", "vue": "^3.4.0", "vue-tsc": "^2.0.0", "typescript": "^5.0.0", "react": "^18.3.1", "react-dom": "^18.3.1" }, "scripts": { "dev": "vite", "build": "vue-tsc --noEmit && vite build", "preview": "vite preview" } }What should remain on the branch after this
Only the core gnosis-vue files:
gnosis-vue/package.json(without Storybook deps)gnosis-vue/tsconfig.jsongnosis-vue/vite.config.tsgnosis-vue/.storybook/main.ts(this was in the original commit, keep it)gnosis-vue/src/index.tsgnosis-vue/src/utils/withVModel.tsThe following is the prior conversation context from the user's chat exploration (may be truncated):
User: I dont see any stories for components can we resuse some of the code between the 2 storybooks?
Assistant:
Good question. The existing React stories use JSX templates like
<Button size="sm" {...args} />— those can't run in a Vue Storybook directly. But we can reuse the non-UI parts: theargTypes,args,optionsarrays, andmetaconfig. The only thing that changes is therenderfunction.Here's the approach:
1. Extract shared story config into
.meta.tsfilesTake the existing React story and split out everything except the JSX: