Skip to content

Remove Storybook files from gnosis-vue directory branch (PR #629 cleanup)#631

Merged
marios-tsigkas merged 2 commits into
copilot/add-gnosis-vue-directoryfrom
copilot/remove-storybook-files
Mar 10, 2026
Merged

Remove Storybook files from gnosis-vue directory branch (PR #629 cleanup)#631
marios-tsigkas merged 2 commits into
copilot/add-gnosis-vue-directoryfrom
copilot/remove-storybook-files

Conversation

Copilot AI commented Mar 10, 2026

Copy link
Copy Markdown

Description

Strips all Storybook-related additions from copilot/add-gnosis-vue-directory so PR #629 stays focused on the core gnosis-vue wrapper. The Storybook config, Vue stories, shared .meta.ts files, and related package.json changes belong in PR #630 (copilot/add-shared-meta-files).

Changes

Deleted:

  • gnosis-vue/.storybook/preview.ts
  • gnosis-vue/src/stories/ — all 7 Vue story files (Button, Input, Alert, Tag, Text, Chip, Toast)
  • src/components/Button/Button.meta.ts, Alert.meta.ts, Tag.meta.ts, Text.meta.ts

Reverted:

  • gnosis-vue/package.json — removed Storybook devDependencies (@storybook/vue3-vite, addons, storybook) and storybook/build:storybook scripts

Kept (original PR #629 scope):

  • gnosis-vue/.storybook/main.ts
  • gnosis-vue/src/index.ts, src/utils/withVModel.ts
  • gnosis-vue/package.json core deps, tsconfig.json, vite.config.ts

Fixes

Original prompt

Summary

Remove all Storybook-related files from the copilot/add-gnosis-vue-directory branch so that PR #629 stays focused on the core gnosis-vue wrapper only. The Storybook stuff belongs in PR #630 (copilot/add-shared-meta-files).

IMPORTANT: Do NOT create a new branch or a new PR. Push changes directly to the existing copilot/add-gnosis-vue-directory branch.

Files to DELETE from copilot/add-gnosis-vue-directory

Vue Storybook config

  • gnosis-vue/.storybook/preview.ts

Vue story files

  • gnosis-vue/src/stories/Button.stories.ts
  • gnosis-vue/src/stories/Input.stories.ts
  • gnosis-vue/src/stories/Alert.stories.ts
  • gnosis-vue/src/stories/Tag.stories.ts
  • gnosis-vue/src/stories/Text.stories.ts
  • gnosis-vue/src/stories/Chip.stories.ts
  • gnosis-vue/src/stories/Toast.stories.ts

Shared meta files (these belong in PR #630)

  • src/components/Button/Button.meta.ts
  • src/components/Alert/Alert.meta.ts
  • src/components/Tag/Tag.meta.ts
  • src/components/Text/Text.meta.ts

Revert gnosis-vue/package.json

Replace the current gnosis-vue/package.json (blob sha: 89c193eeeaff05b1f07d0a4bd5320c5150312a8e) with the original version that does NOT have Storybook devDependencies or scripts. The file should be:

{
  "name": "@epignosis_llc/gnosis-vue",
  "version": "1.0.0",
  "type": "module",
  "description": "Vue 3 wrapper for the Epignosis Gnosis design system",
  "main": "dist/gnosis-vue.umd.cjs",
  "module": "dist/gnosis-vue.js",
  "types": "dist/types/index.d.ts",
  "exports": {
    ".": {
      "types": "./dist/types/index.d.ts",
      "import": "./dist/gnosis-vue.js",
      "require": "./dist/gnosis-vue.umd.cjs"
    }
  },
  "files": ["dist"],
  "peerDependencies": {
    "vue": "^3.3.0",
    "react": ">=18.0.0",
    "react-dom": ">=18.0.0"
  },
  "dependencies": {
    "@epignosis_llc/gnosis": "^6.6.3",
    "veaury": "^2.6.0"
  },
  "devDependencies": {
    "@vitejs/plugin-vue": "^5.0.0",
    "@vitejs/plugin-react": "^4.0.0",
    "vite": "^5.0.0",
    "vite-plugin-dts": "^3.0.0",
    "vue": "^3.4.0",
    "vue-tsc": "^2.0.0",
    "typescript": "^5.0.0",
    "react": "^18.3.1",
    "react-dom": "^18.3.1"
  },
  "scripts": {
    "dev": "vite",
    "build": "vue-tsc --noEmit && vite build",
    "preview": "vite preview"
  }
}

What should remain on the branch after this

Only the core gnosis-vue files:

  • gnosis-vue/package.json (without Storybook deps)
  • gnosis-vue/tsconfig.json
  • gnosis-vue/vite.config.ts
  • gnosis-vue/.storybook/main.ts (this was in the original commit, keep it)
  • gnosis-vue/src/index.ts
  • gnosis-vue/src/utils/withVModel.ts

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: I dont see any stories for components can we resuse some of the code between the 2 storybooks?

Assistant:

Good question. The existing React stories use JSX templates like <Button size="sm" {...args} /> — those can't run in a Vue Storybook directly. But we can reuse the non-UI parts: the argTypes, args, options arrays, and meta config. The only thing that changes is the render function.

Here's the approach:

1. Extract shared story config into .meta.ts files

Take the existing React story and split out everything except the JSX:

// Shared between React and Vue Storybooks — no JSX, no framework code
import { colors } from "@theme/default/colors";

export const buttonMeta = {
  title: "Components/Button",
  argTypes: {
    onClick: { action: "clicked" },
    color: {
      control: {
        type: "select",
        options: ["primary", "secondary", "danger", "success", "primaryLight"],
      },
    },
  },
  args: {
    disabled: false,
    isLoading: false,
    block: false,
    noGutters: false,
    rounded: false,
    as: "button",
    underlined: false,
    active: false,
  },
};

export const primaryArgs = { color: "primary", children: "Primary" };
export const secondaryArgs = { color: "secondary", children: "Secondary" };
export const dangerArgs = { color: "danger", children: "Danger" };
export const successArgs = { color: "success", children: "Success" };
export const primaryLightArgs = {
  color: "primaryLight",
  children: "Primary light",
  style: { background: colors.primary.darker, padding: "1.25rem 1.25rem 0.25rem" },
};
export const primaryDarkerArgs = { color: "primaryDarker", children: "Primary darker" };
export const orangeArgs = { color: "orange", children: "Orange" };
export const inputMeta = {
  title: "components/Form Elements/Input",
  argTypes: {
    size: {
      control: { type: "select", options: ["sm", "md", "lg"] },
    },
    status: {
      control: { type: "select", options: ["valid", "error"] },
    },
    autoFocus: {
      control: { type: "boolean" },
    },
  },
  args: {
    id: "input",
    size: "md",
    ...

</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

*This pull request was created from Copilot chat.*
>

<!-- START COPILOT CODING AGENT TIPS -->
---

 Let Copilot coding agent [set things up for you](https://github.com/epignosis/gnosis/issues/new?title=+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove Storybook-related files from gnosis-vue branch Remove Storybook files from gnosis-vue directory branch (PR #629 cleanup) Mar 10, 2026
@marios-tsigkas
marios-tsigkas marked this pull request as ready for review March 10, 2026 12:39
@marios-tsigkas
marios-tsigkas merged commit 05a1c8a into copilot/add-gnosis-vue-directory Mar 10, 2026
@marios-tsigkas
marios-tsigkas deleted the copilot/remove-storybook-files branch March 10, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants