Skip to content

adjust for quaver parser - #3

Merged
enssow merged 2 commits into
sorcha/dev/2647from
iluise/dev/2647
Jul 20, 2026
Merged

adjust for quaver parser#3
enssow merged 2 commits into
sorcha/dev/2647from
iluise/dev/2647

Conversation

@iluise

@iluise iluise commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Description

Adjust for quaver parser + use source window start as init time

Issue Number

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@enssow
enssow merged commit b4ef9cb into sorcha/dev/2647 Jul 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants