test: add ingestion fallback contract tests#44
Merged
Conversation
Proves the pipeline stays notes-first and safe when web evidence is absent or the web provider fails: local retrieval happens before web fetch, empty/failed providers produce a doNotSave draft without crashing, and the LLM prompt contains only gathered evidence — not ungrounded content.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves the pipeline stays notes-first and safe: local retrieval always happens before web fetch, empty/failed web providers produce a doNotSave draft without crashing (verified via BraveEvidenceProvider with network errors and HTTP errors), and the LLM receives actual gathered evidence — not invented content. 13 new tests, 229 passing before, 242 after.
Changed files: test/ingestion_fallback_contract_test.dart
Tests run: flutter analyze (clean), flutter test (242 passed, 13 added, 0 regressions)
Risks / follow-up: none — test-only change
Not changed: production ingestion behavior, Brave settings/provider code, UI, persistence, markdown generation