Skip to content

test: add note export round-trip tests#41

Merged
enlorik merged 1 commit into
mainfrom
feature/note-export-round-trip-tests-clean
Jun 8, 2026
Merged

test: add note export round-trip tests#41
enlorik merged 1 commit into
mainfrom
feature/note-export-round-trip-tests-clean

Conversation

@enlorik

@enlorik enlorik commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Supersedes PR #36 because the original branch may contain stale stacked history.

Added test/note_export_round_trip_test.dart with 10 focused tests verifying that generated note content survives the full export cycle. Tests cover Note.toJson/fromJson preserving HTML metadata comments verbatim, sequential append preserving both the first save's and second save's metadata blocks, source URLs surviving through saveAsNewNote and JSON serialization, and confirming no API keys or secret-like strings appear in exported content. Also checks that double-dash sanitization keeps the HTML comment block valid.

Changed files

  • test/note_export_round_trip_test.dart (new)

Tests run

  • flutter analyze — no issues
  • flutter test — 229 passed (was 219 before; 10 new tests added, zero regressions)

Risks / follow-up

  • No production code changed; risk is near zero.

Intentionally not changed

  • Production export behavior (note_draft_review_provider.dart)
  • Persistence architecture or database layer
  • Evidence generation, markdown generation format
  • Brave settings/provider code
  • SearchScreen wiring

@enlorik enlorik marked this pull request as ready for review June 8, 2026 16:56
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@enlorik enlorik merged commit 6423ec5 into main Jun 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant