test: add note export round-trip tests#41
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes PR #36 because the original branch may contain stale stacked history.
Added
test/note_export_round_trip_test.dartwith 10 focused tests verifying that generated note content survives the full export cycle. Tests cover Note.toJson/fromJson preserving HTML metadata comments verbatim, sequential append preserving both the first save's and second save's metadata blocks, source URLs surviving through saveAsNewNote and JSON serialization, and confirming no API keys or secret-like strings appear in exported content. Also checks that double-dash sanitization keeps the HTML comment block valid.Changed files
test/note_export_round_trip_test.dart(new)Tests run
flutter analyze— no issuesflutter test— 229 passed (was 219 before; 10 new tests added, zero regressions)Risks / follow-up
Intentionally not changed
note_draft_review_provider.dart)