fix(dogfood 2026-06-16-e2e): data-aware dashboard empty state + finding reconciliation (ISSUE-001..005)

[engels74]

Summary

Triage-first remediation of the 2026-06-16 end-to-end dogfood findings (dogfood-output/report.md, ISSUE-001..005 + INFO-001). The run reported PASS overall with 5 low-severity items. On code inspection, 2 of 5 were contradicted by the source and 1 is by-design, so this change fixes only what is real, satisfies the discoverability intent without regressing a load-bearing invariant, and closes the false positives with evidence rather than padding the diff.

Changes

ISSUE-003 - Dashboard empty-state copy is now data-aware (confirmed bug)

The /dashboard subtitle previously read "Your Plex Wrapped for {year} is ready to explore" unconditionally, including for members with no synced history (whose personal Wrapped then shows an empty state). The subtitle is now gated on the existing wrappedHref signal: data-having members keep the original copy; no-data members get accurate empty-state copy. No new server call and no share_settings mint.

ISSUE-004 - No-data personal-card affordance (resolved by copy; link-gating is by-design)

No-data members now see a static, non-link empty-state personal card explaining where and when their Wrapped will appear. A live personal-Wrapped link is intentionally withheld for 0-play users: getOwnerWrappedHrefIfData returns null by design to prevent SvelteKit hover-preload firing a 404 and to prevent getOrCreateShareSettings lazily minting a share_settings row on every no-data load (the duplicate-row HIGH-severity incident class from #150). The affordance is a <div>, not an <a>, and contains no /wrapped/.../u/... href, hand-constructed or computed.

ISSUE-002 - Confirm-dialog focus behavior (verified, documented)

The bulk-apply confirmation dialog on /admin/settings/privacy already uses the focus-trapping bits-ui AlertDialog.Content primitive. Added source-guard tests pinning that wiring. No production change: a Bun source suite cannot assert runtime focus movement, so this documents and locks the primitive rather than hand-rolling a trap. Escalate to a Playwright assertion only if the trap is ever proven broken.

ISSUE-001 - Console JSON-parse warning (closed as external)

No unguarded client-side JSON.parse runs on /wrapped/2026: the only client parses are try/catch-guarded (sync-status.svelte.ts) or live on other routes (admin logs/sync, onboarding, plex-login). The literal text Unable to parse JSON: "undefined" is not V8/Bun native wording (native begins with Unexpected token), indicating a third-party script - consistent with the Google Identity Services deprecation warning observed on the same page. No code change.

ISSUE-005 - Thumbnail-proxy token TTL (false positive, closed with proof)

The token TTL is already 30 minutes (TOKEN_TTL_SECONDS = 30 * 60, single mint path), not ~1 year. The year:2026 payload field is the Wrapped year, not an expiry. Added a decoded-token proof test asserting exp - mint-time is approximately 1800 seconds.

INFO-001 (public landing lookup disabled) is an intentional config choice and out of scope.

Files changed

• src/routes/dashboard/+page.svelte - data-aware subtitle and non-link empty-state personal card
• tests/unit/dashboard/dashboard-empty-state.test.ts (new) - source-guards for the subtitle gate and the no-link affordance
• tests/unit/admin/dogfood-ui-invariants.test.ts - source-guards for the bits-ui AlertDialog focus-trapping primitive
• tests/unit/plex/thumbnail-auth.test.ts - decoded-token ~30-minute TTL proof
• dogfood-output/report.md (gitignored) - status annotations for ISSUE-001..005

Verification

• bun run check - 0 errors
• bun run test - 2151 pass / 0 fail, coverage >= 80% line/function
• bun run check:biome - clean

Notes

• The net code change is intentionally smaller than the finding count: 3 of 5 items were false positives, external, or by-design.
• The getOwnerWrappedHrefIfData / getOwnerWrappedHref helper contracts are unchanged, so the admin blast radius (admin/+layout.server.ts shares the helper) and the fix(dogfood 2026-06-16): remediate ISSUE-001/002/003 #150 no-mint/no-preload invariant are preserved.

[augmentcode]

🤖 Augment PR Summary

Summary: This PR remediates 2026-06-16 dogfood findings by making the dashboard reflect whether a user actually has synced plays for the current year, and by adding “source-guard” tests to prevent regressions.

Changes:

• Dashboard subtitle is now gated on data.wrappedHref, showing an accurate empty-state message when no personal Wrapped link is available.
• Personal Wrapped card now renders a non-link empty-state card (a <div>) when wrappedHref is null, avoiding hover-preload and avoiding minting share settings for 0-play users.
• Adds CSS overrides for .wrapped-card.empty to suppress hover affordances on the non-interactive empty-state card.
• Adds a new unit test file that source-guards the dashboard subtitle gate and the “no-link” invariant for the empty personal card.
• Adds unit source-guards asserting the admin privacy bulk-apply confirm dialog continues to use the bits-ui AlertDialog primitive (focus-trap wiring).
• Adds a thumbnail token test that decodes the JWT and proves the TTL is ~30 minutes (not ~1 year), with CI-robust timing bounds.

Technical Notes: The UI behavior change is driven entirely by the existing wrappedHref signal (no new server calls), and the new tests intentionally validate template wiring via source inspection to cover UI invariants without a DOM harness.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 2 suggestions posted.

Comment augment review to trigger a new review at any time.

[engels74]

augment review

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.