Skip to content

chore(rt-v1): retire promote-release-candidate.yaml (DEVEX-1656)#151

Merged
pdodgen-revparts merged 1 commit into
mainfrom
devex-1656-delete-promote-rc
Jul 10, 2026
Merged

chore(rt-v1): retire promote-release-candidate.yaml (DEVEX-1656)#151
pdodgen-revparts merged 1 commit into
mainfrom
devex-1656-delete-promote-rc

Conversation

@pdodgen-revparts

Copy link
Copy Markdown
Contributor

Context

RT v2 has landed successfully. Retiring the v1 promote orchestrator per docs/promote-release-candidate-retirement.md in encodium/actions.

Simplified from the retirement doc

The retirement doc originally called for three PRs — two per-caller cleanup (webstore + internal_api Start Release Train.yaml) plus this delete. Both callers are already goneStart Release Train.yaml doesn't exist in webstore or internal_api. So this collapses to one PR: the delete.

Verified via per-workflow grep across all 22 RT participants plus encodium/.github and encodium/actions. Nothing invokes this file.

Rollback

Revert this PR. RT v1 was never destructive — the legacy rc branches, *-main.N tags in git history, and mathieudutour release_branches overrides in each participant continue to exist even without this orchestrator. This workflow was purely orchestration on top of state that lives elsewhere.

Companion work

  • 22 draft PRs across every RT participant scrubbing rc gate references + Jellyfish notify jobs (in-flight — see task ci: update docker layer caching action #59 in the sweep report)
  • encodium/terraform#3471 — remove rc branch + protection blocks for manage + internal_api (draft)
  • Follow-up delete of jellyfish-deploy-notification.yaml after every caller PR lands
  • gh api DELETE rc branches on the ~10 repos where they exist, after the participant sweep merges

RT v2 has landed successfully and the retirement criteria in
docs/promote-release-candidate-retirement.md (in encodium/actions) are
met.

The retirement doc originally called for three PRs: webstore +
internal_api per-caller cleanup, plus this delete. Both callers are
already gone — Start Release Train.yaml doesn't exist in webstore or
internal_api. So this is just the delete.

Verified no other callers via per-workflow grep across all 22 RT
participants + encodium/.github + encodium/actions. Nothing invokes
this file.

Rollback: revert this PR. RT v1 was never destructive — the legacy rc
branches, *-main.N tags in git history, and the mathieudutour
release_branches overrides in each participant continue to exist even
without this orchestrator. The workflow was purely orchestration on
top of state that lives elsewhere.

Companion work landing in parallel:
- Participant workflow sweep (rc gate removal + Jellyfish scrub) —
  22 draft PRs (DEVEX-1653 retire)
- encodium/terraform rc block removal for manage + internal_api —
  DEVEX-1653 retire-rc-branches PR (draft)
- rc branch deletion via gh api after the sweep merges
- Delete jellyfish-deploy-notification.yaml after per-repo jellyfish
  jobs are gone (blocked on sweep merge)
@cursor

cursor Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Deletes unused CI orchestration with no runtime app impact; rollback is reverting the file if something still depended on it.

Overview
Removes the entire .github/workflows/promote-release-candidate.yaml reusable workflow (~200 lines), retiring the Release Train v1 “promote -main.N → pretty RC tag” orchestrator.

That workflow previously resolved the latest (or explicit) *-main.N tag, derived the pretty version, force-pushed the rc branch, retagged container images (including optional extra refs), optionally synced S3 CDN assets, and created a prerelease GitHub release. No replacement is added in this diff — promotion is handled elsewhere under RT v2.

Per the PR context, callers were already removed from participant repos; this change only deletes the shared workflow definition.

Reviewed by Cursor Bugbot for commit 60a4fe6. Bugbot is set up for automated code reviews on this repo. Configure here.

@pdodgen-revparts
pdodgen-revparts marked this pull request as ready for review July 10, 2026 18:00
@pdodgen-revparts
pdodgen-revparts requested a review from a team as a code owner July 10, 2026 18:00
@pdodgen-revparts
pdodgen-revparts merged commit 8fa3c8c into main Jul 10, 2026
2 checks passed
@pdodgen-revparts
pdodgen-revparts deleted the devex-1656-delete-promote-rc branch July 10, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant