Skip to content

feat(slack-deploy-notification): include version + diff since last prod release #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pdodgen-revparts merged 1 commit into from
Jul 8, 2026
Merged

feat(slack-deploy-notification): include version + diff since last prod release #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion .github/workflows/slack-deploy-notification.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,47 @@ jobs:
notify:
runs-on: ubuntu-latest
steps:
# Compute the previous production release tag by walking the GH
# Releases API and picking the most recent non-current, non-draft,
# non-prerelease entry. Callers gate this workflow on
# `inputs.environment == 'prod'`, so filtering out prereleases yields
# the previous prod release specifically. Enables a compare link in
# the Slack message so folks can see exactly what shipped.
- name: Compute previous prod release + diff link
id: diff
env:
GH_TOKEN: ${{ github.token }}
CURRENT_TAG: ${{ inputs.image_tag }}
run: |
set -euo pipefail
PREV_TAG=$(gh release list \
--repo "${{ github.repository }}" \
--exclude-drafts \
--exclude-pre-releases \
--json tagName,publishedAt \
--limit 50 \
| jq -r --arg cur "$CURRENT_TAG" \
'[.[] | select(.tagName != $cur)] | sort_by(.publishedAt) | reverse | .[0].tagName // ""')
if [ -n "$PREV_TAG" ]; then
COMPARE_URL="${{ github.server_url }}/${{ github.repository }}/compare/${PREV_TAG}...${CURRENT_TAG}"
# Slack mrkdwn: leading tab preserves the indented-bullet style
# used by the other lines in the payload.
DIFF_LINE="\n\t<${COMPARE_URL}|View changes since ${PREV_TAG}>"
echo "Previous prod release: $PREV_TAG"
echo "Compare URL: $COMPARE_URL"
else
# First prod release for this repo — nothing to diff against.
DIFF_LINE=""
echo "No previous prod release found — first-time prod deploy."
fi
{
echo "previous_tag=$PREV_TAG"
echo "diff_line<<EOF"
printf '%s' "$DIFF_LINE"
echo
echo "EOF"
} >> "$GITHUB_OUTPUT"

@cursor cursor Bot Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiline output breaks Slack JSON

High Severity

The diff_line step output is written with a multiline GITHUB_OUTPUT block that includes an extra echo after printf, so the stored value ends with a real newline. That output is pasted raw into the Slack payload JSON text field, which produces invalid JSON and can cause the notification step to fail on prod deploys.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c2ec023. Configure here.


- name: Send deployment notification
uses: slackapi/[email protected]
env:
Expand All @@ -42,7 +83,7 @@ jobs:
"type": "section",
"text": {
"type": "mrkdwn",
"text": "*${{ github.event.repository.name }} deployed by ${{ github.triggering_actor }}*\n\tView the <${{ inputs.dashboard_url }}|Deployment>\n\tView the <${{ inputs.apm_url }}|Service APM>"
"text": "*${{ github.event.repository.name }} deployed by ${{ github.triggering_actor }}*\n\tVersion: `${{ inputs.image_tag }}`\n\tView the <${{ inputs.dashboard_url }}|Deployment>\n\tView the <${{ inputs.apm_url }}|Service APM>${{ steps.diff.outputs.diff_line }}"
},
"accessory": {
"type": "button",
Expand Down