fix(description): show all accepted arm_type values in error#73
Merged
Conversation
When an invalid arm_type is given, list every accepted value derived from VALID_ARM_TYPES instead of hardcoding two names, so the error stays correct as new arm types are added.
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #71 as requested by @kou (thanks for the review!).
This PR does one thing: when an invalid
arm_typeis supplied, the error now lists every accepted value derived fromVALID_ARM_TYPESinstead of hardcodingopenarm_v1.0 or openarm_v2.0. This keeps the message correct automatically as new arm types are added.Companion to the URDF-cleanup split in the sibling PR.