Skip to content

fix(description): drop generated root URDFs and ignore them #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bartok9 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(description): drop generated root URDFs and ignore them #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# *.urdf
# Ignore generated URDFs at package root (launch builds on the fly)
*.urdf
!assets/**/*.urdf
!assets/**/*.urdf.xacro
Comment on lines +16 to +18

@kou kou Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*.urdf
!assets/**/*.urdf
!assets/**/*.urdf.xacro
/*.urdf

**/build/*
/backup
**/base_urdf_ws
Expand All @@ -37,4 +40,7 @@ __pycache__
/urdf/

docs/
scripts/
scripts/
# Accidental gen scratch files (never ship)
/openarmv2.urdf
/output.urdf

@kou kou Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove them?

Empty file removed openarmv2.urdf
View file
Open in desktop
Empty file.
Loading