refactor(ctr): relocate root container pause target to /.kukeon/bin/kukepause - #980
Merged
Conversation
Owner
Author
Review: refactor(ctr): relocate root container pause target to /.kukeon/bin/kukepauseVerdict: LGTM ✅ SummaryMinimal, correctly scoped change. The single functional edit is the Correctness
Commit signature
Non-blocking nit
Reviewed by pr-reviewer agent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/pauseto the kukeon-namespaced/.kukeon/bin/kukepause(issue refactor(ctr): relocate root container pause binary target from /pause to /.kukeon/bin/kukepause #979).RootContainerPauseBinaryTargetconstant ininternal/ctr/container_utils.go. Both the OCI bind-mountTargetand the root container'sCommandderive from it, so they move together; tests assert against the constant (not the literal), so they follow automatically./pausereferences incmd/kuke/init/init.go,cmd/kukepause/main.go,internal/controller/runner/kukepause.go,internal/controller/runner/provision.go,internal/ctr/container_utils.go, andinternal/ctr/container_utils_test.go(comments only). The bind source basename (RootContainerPauseBinaryName="kukepause", staged at<RunPath>/bin/kukepause) is decoupled and unchanged, per the issue's scope analysis.Recovery note
Recovered from a prior session that crashed after implementing the change but before committing (left uncommitted on
main, branch unpushed). The operator confirmed no other agent was live before recovery. The diff matches the issue's stated scope exactly (6 files, +21/-19).Test plan
go build ./...go vet ./...make test(root-module unit suite incl.internal/ctr,internal/controller/runner, allcmd/*,cmd/kukepause, plus thekukebuildmodule) — green with a shortTMPDIR. The default long/tmp/claude-*path otherwise trips an unrelatedSUN_PATH > 107limit inattachable_test.go(a known host-env constraint, not a regression from this change)./pauseliterals outsidekukepausepaths — none remain.make e2e— not run: the e2e suite needs the docker-built local kukeond image + containerd harness, unavailable in this dev session. The e2e cases that exercise cell create/start/attach are the runtime path that confirms the nested mount; deferred to the reviewer's clean host.make dev-initsmoke parity + nested-mount runtime checks (AC: default-root cell starts with kukepause as PID 1; nested/.kukeon/bin/kukepausetarget auto-created on stock busybox and on aReadOnlyRootFilesystemroot container) — not run:make dev-initis a destructive smoke that resets the livekukeondcell, and this session's tool-output observability was degraded; running it blind risked leaving the host daemon indeterminate. runc auto-creating the bind destination's parent dirs is the one path the unit tests don't cover and should be confirmed on a clean host.Closes #979