Add support for NoDebugAttr#827
Conversation
elliotchance
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
elliotchance
left a comment
There was a problem hiding this comment.
This PR is fine, but there are build failures unrelated to the change because it looks like travis has changed their underlying image. As to not break dev, I will put in a PR to update the build first.
Reviewable status:
complete! all files reviewed, all discussions resolved
|
I have tried to update go and clang. However, there are a few years of upgrades and the changes are not trivial: #828 The next few months will be too busy for me to visit this project in any more depth. You are welcome to try and get the build working with my changes and I will happily review and merge it. Unfortunately this means this PR will remain stalled until then. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
=========================================
Coverage ? 77.86%
=========================================
Files ? 170
Lines ? 9814
Branches ? 0
=========================================
Hits ? 7642
Misses ? 1695
Partials ? 477
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Fixes
panic: unknown node type: 'NoDebugAttr 0x2ebd788 <col:59>'This change is