Skip to content

Convert round calls to math.Round #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
icholy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Convert round calls to math.Round #777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
395335a
convert round calls to math.Round
icholy Jul 10, 2018
b6db698
update tests
icholy Jul 11, 2018
252b34a
update number of expected tests
icholy Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions program/function_definition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ var builtInFunctionDefinitions = map[string][]string{
"double log(double) -> math.Log",
"double log10(double) -> math.Log10",
"double pow(double, double) -> math.Pow",
"double round(double) -> math.Round",
"double sin(double) -> math.Sin",
"double sinh(double) -> math.Sinh",
"double sqrt(double) -> math.Sqrt",
Expand Down
17 changes: 16 additions & 1 deletion tests/math.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ unsigned long long ullmax = 18446744073709551615ull;

int main()
{
plan(359);
plan(372);

// Note: There are some tests that must be disabled because they return
// different values under different compilers. See the comment surrounding the
Expand Down Expand Up @@ -400,6 +400,21 @@ int main()
is_nan(pow(-INFINITY, NAN));
is_nan(pow(NAN, NAN));

diag("round");
is_eq(round(0), 0);
is_eq(round(1), 1);
is_eq(round(-1), -1);
is_eq(round(0.5), 1);
is_eq(round(-0.5), -1);
is_eq(round(0.4), 0);
is_negzero(round(-0.4));
is_eq(round(1.23e300), 1.23e300);
is_eq(round(-1.23e300), -1.23e300);
is_eq(round(M_PI), 3);
is_inf(round(INFINITY), 1);
is_inf(round(-INFINITY), -1);
is_nan(round(NAN));

diag("sin");
is_eq(sin(0), 0);
is_eq(sin(1), 0.84147098480789650488);
Expand Down