Ptycho constraints#237
Closed
arthurmccray wants to merge 20 commits into
Closed
Conversation
…lti GPU compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to PR #234 that does 3 main things:
ConstraintParamsdataclasses for tab-completable and better-documented constraints. Tutorial for that herepure_phaseptycho objects to being stored as realvalued arrays. This prevents issues of phase wrapping (especially with DIPs) and makes regularization and filtering more consistent/accurate. It does make it fairly duplicitous topotentialobjects, but I think it can be left for the time being.torch.no_grad. This doesn't make much of an difference in results, but it's cleaner and the more standard way of doing hard constraints.I think it makes sense to keep this PR separate from #234, though it does fix a bug where the first GPU(s) are initialized incorrectly.
Both PRs need to wait for #213 to be merged into dev and tested to make sure non breaking.