github: pick the host's libc variant, with fallback (#279)#283
Merged
Conversation
The GitHub-release executor tagged every asset variant=Any, so on a glibc host a `*-musl` asset was indistinguishable from the glibc one and could be picked - then fail to run (No such file or directory). Detect musl in the asset name (Linux only) and tag the variant, then prefer the host's libc, dropping the other only when it's the sole build for a given os/arch/version - so a musl-only static linux build still resolves on glibc, and vice versa. Survivors are normalised to Any so the shared matcher doesn't then hard-drop a chosen fallback. Verified on a glibc host: pnpm (ships both) picks the glibc build; sccache (musl-only) still resolves and runs.
eirikb
enabled auto-merge (squash)
June 28, 2026 20:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitHub-release executor tagged every asset variant=Any, so on a glibc host a
*-muslasset was indistinguishable from the glibc one and could be picked - then fail to run (No such file or directory).Detect musl in the asset name (Linux only) and tag the variant, then prefer the host's libc, dropping the other only when it's the sole build for a given os/arch/version - so a musl-only static linux build still resolves on glibc, and vice versa. Survivors are normalised to Any so the shared matcher doesn't then hard-drop a chosen fallback.
Verified on a glibc host: pnpm (ships both) picks the glibc build; sccache (musl-only) still resolves and runs.