Skip to content

Remove unused GUI dev dependencies - #1180

Closed
louiss72 wants to merge 1 commit into
eigenwallet:masterfrom
louiss72:agent/remove-unused-deps-775
Closed

Remove unused GUI dev dependencies#1180
louiss72 wants to merge 1 commit into
eigenwallet:masterfrom
louiss72:agent/remove-unused-deps-775

Conversation

@louiss72

@louiss72 louiss72 commented Jul 29, 2026

Copy link
Copy Markdown

What changed

  • Removed three unused direct src-gui dev dependencies:
    • @types/react-redux
    • @testing-library/react
    • @testing-library/user-event
  • Updated yarn.lock to drop the corresponding direct lock entries.

Why

src-gui uses [email protected], which ships its own TypeScript declarations from react-redux/dist/react-redux.d.ts; the external @types/react-redux package targets the older DefinitelyTyped type surface and is no longer needed.

The two Testing Library packages are not imported anywhere under src-gui/src or the frontend config files, and this checkout does not contain frontend test files that use them.

Validation

  • ./node_modules/.bin/eslint src/store/hooks.ts src/renderer/index.tsx
  • TypeScript module resolution check confirmed react-redux resolves to node_modules/react-redux/dist/react-redux.d.ts
  • rg -n "@types/react-redux|@testing-library/react|@testing-library/user-event" src-gui/package.json src-gui/yarn.lock src-gui/src returned no matches
  • git diff --check

Full npm run tsc is still blocked in this checkout by the generated, gitignored src/models/tauriModel.ts being absent. Full npm run eslint is still blocked by existing React Compiler baseline errors unrelated to this dependency removal.

Closes #775

@louiss72
louiss72 force-pushed the agent/remove-unused-deps-775 branch from 8d888a7 to 86766e9 Compare July 29, 2026 05:17
@louiss72 louiss72 changed the title Remove unused react-redux type package Remove unused GUI dev dependencies Jul 29, 2026
@Einliterflasche

Copy link
Copy Markdown

We are not accepting vibe coded PRs. https://github.com/eigenwallet/core/blob/master/AI_POLICY.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[0.02 XMR per task] Remove unused dependencies

2 participants