Remove unused GUI dev dependencies - #1180
Closed
louiss72 wants to merge 1 commit into
Closed
Conversation
louiss72
force-pushed
the
agent/remove-unused-deps-775
branch
from
July 29, 2026 05:17
8d888a7 to
86766e9
Compare
|
We are not accepting vibe coded PRs. https://github.com/eigenwallet/core/blob/master/AI_POLICY.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
src-guidev dependencies:@types/react-redux@testing-library/react@testing-library/user-eventyarn.lockto drop the corresponding direct lock entries.Why
src-guiuses[email protected], which ships its own TypeScript declarations fromreact-redux/dist/react-redux.d.ts; the external@types/react-reduxpackage targets the older DefinitelyTyped type surface and is no longer needed.The two Testing Library packages are not imported anywhere under
src-gui/srcor the frontend config files, and this checkout does not contain frontend test files that use them.Validation
./node_modules/.bin/eslint src/store/hooks.ts src/renderer/index.tsxreact-reduxresolves tonode_modules/react-redux/dist/react-redux.d.tsrg -n "@types/react-redux|@testing-library/react|@testing-library/user-event" src-gui/package.json src-gui/yarn.lock src-gui/srcreturned no matchesgit diff --checkFull
npm run tscis still blocked in this checkout by the generated, gitignoredsrc/models/tauriModel.tsbeing absent. Fullnpm run eslintis still blocked by existing React Compiler baseline errors unrelated to this dependency removal.Closes #775