Improve grammar parser error recovery around malformed productions#79
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for using the reserved error terminal in precedence declarations to resolve shift/reduce conflicts from panic-mode recovery productions. It updates the parser rules to handle malformed inputs gracefully, adds corresponding unit tests, and updates the documentation. Feedback is provided regarding a typo (fisrt instead of first) in the parser error recovery logic.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorrecovery productions for malformed rule bodies, symbol bindings, terminal sets, reduce actions, and%allowtargets.errorterminal into the core parser builder.errorcan participate in precedence declarations for recovery-related conflict resolution.